Skip to end of metadata
Comment: Migrated to Confluence 4.0
Go to start of metadata
  1. Remove signature render( File, File ), it can by default just call render( File, File, null )
  2. Replace render( File, File, File ) by render( File, File, DocumentModel ). Reason: we have to be able to generate some output without a physical documentDescriptor File. Eg for a maven pdf plugin, we could construct the information from site.xml and pom settings.
  3. Remove throws IOException; ? DocRendererException should be enough.
  4. What's the relation with org.apache.maven.doxia.siterenderer.DocumentRenderer and org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer?

 Interface changes

ad 1) and 2): I propose to replace DocRenderer by DocumentRenderer:

Votes

+1: ltheussl, vsiveton
+0:
-1:

Directory structure

Layout like:

+---o.a.m.d.docrenderer
		 DocumentRenderer.java
		...
+---o.a.m.d.docrenderer.pdf
		 PdfRenderer.java
 +---o.a.m.d.docrenderer.pdf.fo
		 	FoPdfRenderer.java
 +---o.a.m.d.docrenderer.pdf.itext
		 	ITextPdfRenderer.java
 +---o.a.m.d.docrenderer.rtf

 +1: ltheussl, vsiveton
+0:
-1:

Labels:
None
Edit Labels

2 Comments

Hide/Show Comments

  1. Sep 12, 2007

    Vincent Siveton

    For 3, Renderer interface (site-renderer) also throws IOException so we need to be constant.

    For 4, I am not sure what you mean: DoxiaDocumentRenderer is the impl of  DocumentRenderer.
    Maybe you ask you about org.apache.maven.doxia.docrenderer.DocRenderer and org.apache.maven.doxia.siterenderer.DocumentRenderer?

  2. Sep 12, 2007

    Lukas Theussl

    I meant: what is the relation/difference between org.apache.maven.doxia.siterenderer.DocumentRenderer and org.apache.maven.doxia.docrenderer.DocRenderer? They seem to be meant for doing quite the same thing...