Agenda: 1) meet sig 2) 2.1.RC0 release 3) updates to build process 4) commiter status for sig
cholmes lperpcich glad you could make it. You want to introduce yourself? We'll get started soon.
lpercich Hi all! First time in #geotools (as well as in IRC and mIRC)... hope I'll not do too many mistakes! :o)
jgarnett Meeting time!
jgarnett (see soon)
lpercich My name is Luca Sigfrido Percich (sig for friends), I'm working with GT in developing a road information system for the municipality of Milan (Italy).
jgarnett grabbing your fix james and trying again.
jgarnett Well met sig
lpercich Nice to meet you all :o)
jgarnett Usually we start with an agenda (otherwise the meetings go on too long).
jgarnett 1) Everyone meet sig 
jgarnett 2) 2.1.RC0 release (tag team with GeoServer)
jgarnett 3) Updates to build process
cholmes 4) commit rights and module maintainer shit for sig on mapinfo
cholmes maintainership I mean
lpercich :oP
jmacgill
jgarnett Fair enough - either way - has sig done a code review? (ie knows how to run maven, jalopy and junit)
jmacgill power glitches here
ianT_ re: 4 - sorry for the delay on reviewing, but I'm recomending acceptance and commit rights
jmacgill lights flickering
lpercich well, just downloaded main trunk with SVN
lpercich and built with maven
ianT_ though I spent all day making my build work again so I didn't get a chance to look at today's new code
lpercich still don't know jalopy
lpercich already using Junit
cholmes You don't? Your code sure looks like it was jalopied.
jgarnett This is why we do the review Jalopy formats the code so we don't argue about bracket placement.
lpercich maybe Eclipse auto-format?
jgarnett I need to set up one that matches Jalopy.
jgarnett Jalopy is available as an eclipse plugin. But yes the default eclipse layout is well neigh the same as what we use.
jgarnett (Different headers)
lpercich can configure it, where can I find the specs?
lpercich I mean headers, style and so on
jgarnett Developers Guide
cholmes he got the headers right...
cholmes But yes, running jalopy is the best.
lpercich Ok, I'll read it deeply
jgarnett Nifty.
lpercich I'll look for jalopy plugin, thanks
jgarnett So yeah it sounded like IanT was willing to vouch - I have not done a code review so I can take his recommendation.
cholmes http://www.geotools.org/Coding+Conventions
cholmes I did a basic code review, it looks solid.
jgarnett Well +1 for me then
ianT_ +1
cholmes ianT_ are you ok with making him co-module maintainer?
cholmes +1
jgarnett (we do voting in a semi binary way -1, +1 and 0 for don't care)
lpercich oh, thanks
cholmes and you passed - you just need 3 +1's from committers
ianT_ he can be whole maintainer if he wants
jmacgill +1
cholmes Cool - add yourself to the project.xml file as module maintainer.
lpercich thanks ian, if you don't have time for me it's ok
lpercich ok, I'll do it
jmacgill power glitched again... scary storm
cholmes And you should not have too many difficulties with maven, since there already is a module set up.
jgarnett In case you get too worried - these tools are run automagically - http://modules.geotools.org/main/checkstyle-report.html
cholmes Just kill the old DataStore.
jgarnett (we are not always doing that well ourselves)
lpercich ok
lpercich you mean, like a cvs remove?
jgarnett I was going to point out "clover" but I dont see it
cholmes In Jody's words (from the comments) 'This is the worst possilble datastore you can imagine...'
jgarnett (it is the tool that tells you how much of your code your unit tests cover)
jgarnett James what happened to clover?
cholmes No, it has the same name as yours, so yours will just be the next revision
lpercich fine then
jmacgill used a lot of memory - versions changed - ran out of personal time to keep it up and running
lpercich ooops... I would call it MIFDataStore, 'cause it uses the MIF format
cholmes But you can get rid of the DataSource when you do that - cvs remove.
lpercich what about keeping MapInfoDataStore for a future support of native format?
cholmes Oh, ok, that's fine. In that case you can cvs remove the old one.
cholmes That sounds good - remove it for now, and then if we do the native format we can bring it back.
lpercich Fine, I'll stick with MIF* then.
ianT_ sounds good to mee
cholmes jgarnett - what's the procedure for svn access - still send to pramsey?
jgarnett yep
jgarnett So welcome sig
jgarnett Hi justin just getting into the swing of things ( I think you forgot some Postgis commits)
jgarnett 2) 2.1.RC0 release - real soon now
jgarnett The build is currently annoying me with images, it has the patches dblasby wants for geoserver.
jdeolive_ i am in the process of merging my postgis changes onto 2.1.x
jgarnett An announcement email will be sent out as part of the geoserver release.
lpercich Thanks jody!
jgarnett Is there anymore questions about 2.1.RC0 - the Jira release notes are fairly clear about what changed.
jmacgill given that it has RC in its name, are we sure there will be no more API changes?
jgarnett Good point, there are two on the books.
jgarnett Martin will update us to the stable GeoAPI later this week (3-4 changes of Array to Collection)
jgarnett And Dzwiers would like to upgrade XDO - but lacks volunteer time himself, and documentation for others.
jgarnett 2.1.RC1 will go out with udig next week.
cholmes Are you doing udig 1.0.0 ?
jgarnett Yes.
dblasby meeting?
dblasby meeting?
jgarnett Is on right now?
jgarnett 3) Updates to build process
jgarnett James want to tell us what is new and improved?
jmacgill Sure...
jmacgill ok, for a while now the auto Cruise Control build has been using the MultiProject plugin to control the build
jmacgill this is far less ad-hock than the old system
jmacgill I have now extended that to all builds (so expect tonights nightly release to be different too)
jmacgill the major chance is in how the list of things to build is created
jmacgill specificaly excluded modules will NO LONGER build built in a normal build (or nightly or cc)
cholmes Could you possibly change the email subject a bit? In my email client all I see is F... which could mean fixed or failed.
jmacgill or 'createRelease' eather'
jmacgill sure
CIA-10 dadler * r14135 geotools/gt/module/sample-data/src/org/geotools/sampleData/ (6 files): GEOT-541 add .prj for shapefiles
jmacgill the main result is that the folowing modules will not build by default....
jmacgill pickle, db2, gtopo30, mapinfo and geometryless
CIA-10 dadler 2.1.x * r14136 geotools/module/sample-data/src/org/geotools/sampleData/ (6 files): GEOT-541 add .prj for shapefiles
jmacgill I saw an email re geometryless today that may get it off the excludes list and I guess mapinfo is about to die
cholmes db2 should be good to go, email today
jmacgill module maintainers are in control they should add/remove themselves from the maven.multiproject.excludes list
jgarnett Quick annoying interruption:
jgarnett zip Building zip: C:\java\geotools\gt\target\distributions\geotools-bin-2.1.RC0.zip
zip Building zip: C:\java\geotools\gt\target\distributions\geotools-src-2.1.RC0.zip
BUILD SUCCESSFUL
jgarnett Please resume.
jmacgill no javadoc?
jgarnett It made a javadoc.
jmacgill if a module braks the cc build for too long I will add it to the excludes list (and thus it will not be in the nightly or any releases)
jmacgill you can find the magic line in build.properties file at the top level
jmacgill they look like this:
jmacgill maven.multiproject.includes=module//project.xml,ext//project.xml,plugin//project.xml,demo//project.xml
jmacgill maven.multiproject.excludes=*/pickle/,/db2/,/gtopo30/,/mapinfo/,/geometryless/*
jmacgill so new modules will be picked up automaticaly unless they are added to the exclude list explicitly
jgarnett James is mockrunner needed?
jmacgill no idea
jmacgill my guess would be no
jgarnett I would like to trim our download size at some point.
jmacgill batik is used for SVG symbol support in the renderers
jgarnett Uploading now - if I can ask:
jgarnett 1) dblasby to try this with geoserver
jgarnett 2) anyone to try a build from the src download
cholmes darn, my dateTime fix won't be in there...
jgarnett 3) And I will try it with udig
jgarnett What is your dateTime fix chris?
jmacgill anyway, thats the upshot of the new build system (use it the same way as before)
jmacgill any questions?
cholmes So temporal attributes toString returns a better formatting.
cholmes I made the fix between when you notified of the branch and when you sent the email.
cholmes And now my svn is f'ed.
cholmes nothing will check out, anywhere.
jgarnett And I can run the script again, dblasby is the person we are slowing up.
lpercich So as soon as I'll put MIFDatastore on main svn trunk it will be built up? Should I work on a separate branch?
jgarnett Do you want to email me the fix?
cholmes Sure.
cholmes Or you can probably just do a diff against the feature.type package.
jgarnett jdeolive (or jdeolive_) ? I know you were working on getting maven to build eclipse .project and .classpath
dblasby I just build jars from my checkout. My checkout is 2.1.x so I'm just going to be using them.
jmacgill as long as it builds it can be on trunk
jgarnett (as a replacement to the gt2eclipse script)
cholmes New DateUtils class, and modifications to the temporalAttributeType
jmacgill if it does not build it can still be on trunk provied you put an entry against the excludes list
jgarnett what revision was you checkout dave?
jdeolive_ yeah, maven has a built in plugin for eclipse
jgarnett (can find out with svn info)
jdeolive_ it builds .classpath and .project files for each module
cholmes lpercich - trunk is not the stable branch, so if you want it in 2.1.x we should talk about getting it in. You'll have to commit it there too.
cholmes Better to make sure all is well on trunk before considering it...
cholmes It's not an api change, so it should be fine.
jdeolive_ at one point i modified the root maven.xml and added a reactor goal to generate them for all modules
jdeolive_ with the new multi project stuff, i am not sure how that changes
cholmes It would be very nice to have that. In the past few weeks I've had some good success tempting people to make gt2 fixes, but then they get so discouraged by trying for half a day to get the source to build...
lpercich I see. Probably it could work in 2.1.x, just tell me what you think is better
cholmes start on trunk.
lpercich I'll do.
cholmes then we'll see. I mean, if it was on 2.1.x then it'd be in both - it's just a question of if we get it in the 2.1.0 release or in 2.2.0
jgarnett James this is a big enough issue that I am tempted to commit .classpath and .project files for people. I have spent several days is support over the last month.
jmacgill how are the files generated?
jmacgill by hand?
jgarnett I have attached .classpath and .project files to the "Eclipse Developers Guide" page. These were only generated with gt2eclipse.
jmacgill or a script?
jgarnett My bad script.
jgarnett I would much rather have a decent maven aware script.
cholmes But we'd better not have too many api changes to 2.2.0 that one can't easily use datastores from 2.2.0 on 2.1.0, or I will be very upset. Which will mean udig and geoserver should be able to use mapinfo as a plug-in
cholmes I'm a big +1 on committing .classpath and .project files
cholmes And I don't even use them...
jgarnett Well I suspect FeatureType will need a pretty big smack.
jmacgill where would they live?
jgarnett depends what you want to do.
cholmes Shouldn't affect the pluggability of datastore.
cholmes Unlike that freaking URI change.
jgarnett 1) a single .classpath and .project file in the top level "gt" folder (no respect for module dependencies)
jgarnett 2) .classpath and .project files in each module
jgarnett #1 I can generate via brute force and the gt2eclipse script
jgarnett #2 Justin could generate using maven
jgarnett Maven is still required to download everything into the maven repository in either solution (and to run testcases)
jgarnett Please try out http://lists.refractions.net/geotools/gt2
jgarnett james something is wrong
jgarnett the bin download is 23.9 MB
CIA-10 jdeolive 2.1.x * r14137 geotools/plugin/postgis/ (4 files in 2 dirs): migrated postgis changes to 2.1.x branch
jmacgill bound to be glitches in a new build system
jgarnett We are including xalan-2.5.1.jar multiple times in the bin download.
jgarnett I will remove duplicates by hand and upload.
jmacgill odd its in the shared folder
jmacgill share test must have broken down
cholmes sweet Geoff Adams said my oracle fix worked.
jgarnett nice!
jmacgill cool
jmacgill dam
jgarnett james justin was telling me that he needs you to rename build.properties as project.properties or something.
jmacgill shared jar test is screwed
jmacgill almost all jars are in there twice
jmacgill ok, will do the rename v.soon
cholmes jdeolive - what changes did you end up doing to postgis?
jgarnett Apparently he had to leave.
jgarnett I think you asked him not optimize the getBounds
jgarnett So the work probably only exists in a udig subclass of PostgisDataStore ...
jgarnett .. I would suspect as an additional method.
jgarnett So even after a diet the bin download is bigger then I remember.
jgarnett Did we forget to turn on compression james?
cholmes Jody, just sent you an email, with two fixes...
cholmes anyone have any clue why my svn is messed?
jgarnett And they need to go on trunk and on 2.1.x?
cholmes I get 400 Bad request (http://svn.geotools.org)
jgarnett No I don't know why you svn is messed. svn cleanup did not work?
cholmes one needs to go on both, one is on trunk, you just need to move it over.
cholmes details in the email.
cholmes no, cleanup didn't work.
jgarnett oh perhaps, when did it stop working for you? You may have mapped it explicitly in your hosts file back when the domain registration process was causing us all grief.
cholmes I'll check...I think I did fix that, though maybe I just changed it.
cholmes Where is my hosts file again?
cholmes Hrm, I def. changed back because I couldn't even see it in a web browser. Now I can see it from a browser, but I can't svn anything
jgarnett C:\WINDOWS\system32\drivers\etc
jgarnett Okay the new improved 15 mb download is up.
cholmes nope, it's clean 
jgarnett I think the increase in size may just be due to new modules (hsql and friends)
jgarnett james should I wait for a patch for the shared jars thing?
jgarnett I assume you have tried a fresh checkout in a empty directory already.
jgarnett That was the last agenda item btw - thanks for the meeting everyone.
jgarnett I got your email. I will apply the patches after 2.1.RC0 is out. I didn't want to give dblasby anything else to worry about.
jgarnett Posting logs.
Labels